-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flushSync
warning for Combobox
component with immediate
prop enabled
#3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
wrap flushSync call in microTask
Fix Jul 5, 2024
flushSync
warning for Combobox
component with immediate
prop enabled
This will make sure that React is able to flush this correctly by delaying the call using a microTask.
Now that it's nested, let's adjust the width of the comments
RobinMalfait
force-pushed
the
fix/issue-3334-3
branch
from
July 5, 2024 15:28
f555b0f
to
734e5aa
Compare
thecrypticace
approved these changes
Jul 5, 2024
This was referenced Jul 27, 2024
This was referenced Aug 15, 2024
This was referenced Aug 31, 2024
This was referenced Sep 18, 2024
Closed
This was referenced Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where React shows a warning that it is not able to use
flushSync
while it's already rendering.The recommended solution in that case is to move the
flushSync
call to a scheduler task or micro task.The scenario where it happens in this case:
This will conditionally render the
Combobox
with theimmediate
prop (which means that it will open once theComboboxInput
receives focus). But theComboboxInput
also has theautoFocus
prop which means that it will focus immediately when it's rendered.Fixes: #3334