Fix initial anchor="selection" state
#3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Instead of relying on the DOM directly, we can compute the `selectedOptionIndex` and rely on the data directly. We will also freeze the value while closing to prevent UI changes.
RobinMalfait
force-pushed
the
fix/anchor-selection
branch
from
bb2d4aa
to
7f3287d
Compare
RobinMalfait
commented
Jun 25, 2024
thecrypticace
approved these changes
Jun 25, 2024
This was referenced Jul 27, 2024
This was referenced Aug 15, 2024
This was referenced Aug 29, 2024
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where using the
anchor="selection"results in an incorrectly positioned anchor panel.This happened because we computed the
indextoo late and didn't re-render to fix up the UI.To solve this, this PR computes it based on actual state instead of DOM nodes.
We will also compute the selected option based on the frozen state. This will prevent UI glitches while closing the
Listbox.