Only handle form reset when defaultValue
is used
#3240
Merged
+51
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where it would call the
onChange
of a<Listbox>
or<Combobox>
component when used inside of a<form>
even if nodefaultValue
was provided. This also happened for the<Checkbox>
and<Switch>
component but for thedefaultChecked
prop.This means that the
onChange
would be called withundefined
which your application might not expect.This PR only calls
onChange
with thedefaultValue
(ordefaultChecked
for<Checkbox>
or<Switch>
components) if it is provided.This PR also has a small refactor to ensure we can safely use
defaultChecked
anddefaultValue
in dependency arrays of hooks.