Implement nullable mode on Combobox in single value mode
#1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you pass a `nullable` prop to the Combobox, then it's possible to unset the Combobox value by setting it to `null`. This is triggered by removing all text from the input which will reset the value itself as well.
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-vue – ./packages/playground-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/4rKf6JvJeSSiSp1AKfNnXMMC5Dbp headlessui-react – ./packages/playground-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/Egaju6ZCSZwBYUZH2v2N9vFJQNif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
nullableprop to theComboboxcomponent which is defaulted tofalse.If this prop is provided, and you clear the text in the input value, then the
Comboboxoption willbe cleared as well. We will do that by calling your
onChangewithnullin React, or setting thev-modeltonullin Vue.This feature allows you to "clear" a Combobox value once it is set, whereas otherwise this isn't
possible unless you provide a custom "Unset"
Combobox.Optionor a button to reset the value.