Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward the ref to all components #1116

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Forward the ref to all components #1116

merged 3 commits into from
Feb 24, 2022

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Feb 18, 2022 •
edited
Loading

This PR will ensure that you can add the ref prop to all the components we expose.

Fixes: #273
Fixes: #664

@vercel
Copy link

vercel bot commented Feb 18, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

headlessui-vue – ./packages/playground-vue

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/29k73RrPAgcat4HJhmp2ioEMUCgK
✅ Preview: https://headlessui-vue-git-ref-all-the-components-tailwindlabs.vercel.app

headlessui-react – ./packages/playground-react

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/824GpohhfxGMXqJFngmF57Z84RDe
✅ Preview: https://headlessui-react-git-ref-all-the-components-tailwindlabs.vercel.app

@RobinMalfait RobinMalfait force-pushed the ref-all-the-components branch from d720237 to e999fa7 Compare February 18, 2022 21:56
@RobinMalfait
forward ref to all components
ceed6ce
@RobinMalfait
fix playground pages
397e826 
This isn't a perfect fix of course. But the TypeScript changes required
to do it properly are a bit bigger and require more work.

Having this ready is a good step forward.
@RobinMalfait RobinMalfait force-pushed the ref-all-the-components branch from e999fa7 to 397e826 Compare February 24, 2022 15:10
@RobinMalfait RobinMalfait marked this pull request as ready for review February 24, 2022 15:11
@RobinMalfait RobinMalfait merged commit 26670d2 into main Feb 24, 2022
@RobinMalfait RobinMalfait deleted the ref-all-the-components branch February 24, 2022 15:13
This was referenced Feb 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: <Popover> component does not use forwardRef Can't get access to ref on Transition.Child or Transition
1 participant
@RobinMalfait