Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled RadioGroup.Option should have attribute aria-disabled=true #515

Closed
zoltangy opened this issue May 12, 2021 · 1 comment
Closed

Disabled RadioGroup.Option should have attribute aria-disabled=true #515

zoltangy opened this issue May 12, 2021 · 1 comment
Assignees
@RobinMalfait
Labels
Improvement

Comments

@zoltangy
Copy link

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

v1.2.0

What browser are you using?

Chrome

Reproduction repository

Describe your issue

A disabled RadioGroup.Option should have attribute aria-disabled=true.
Also, when disabling the whole RadioGroup, it should have the attribute aria-disabled=true.
RobinMalfait added a commit that referenced this issue May 19, 2021
@RobinMalfait
add aria-disabled to RadioGroup Options
fb4c453 
This will happen when:
- The RadioGroup is disabled
- The RadioGroup Option is disabled

Closes: #515
@RobinMalfait RobinMalfait mentioned this issue May 19, 2021
Merged
RobinMalfait added a commit that referenced this issue May 19, 2021
@RobinMalfait
add aria-disabled to RadioGroup Options (#543)
e87cf72 
* add aria-disabled to RadioGroup Options

This will happen when:
- The RadioGroup is disabled
- The RadioGroup Option is disabled

Closes: #515

* update changelog
@RobinMalfait RobinMalfait self-assigned this May 19, 2021
@RobinMalfait RobinMalfait changed the title [Bug]: disabled RadioGroup.Option should have attribute aria-disabled=true Disabled RadioGroup.Option should have attribute aria-disabled=true May 19, 2021
@RobinMalfait
Copy link
Member

Hey! Thank you for your feature suggestion!
Much appreciated! 🙏

This should be fixed, and will be available in the next release.
You can already try it using npm install @headlessui/react@dev or yarn add @headlessui/react@dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobinMalfait RobinMalfait

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RobinMalfait @zoltangy