Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1.3]: Popover issues with transition prop #3438

Closed
Dragate opened this issue Aug 26, 2024 · 6 comments · Fixed by #3448
Closed

[2.1.3]: Popover issues with transition prop #3438

Dragate opened this issue Aug 26, 2024 · 6 comments · Fixed by #3448
Assignees

Comments

@Dragate
Copy link

Dragate commented Aug 26, 2024

What package within Headless UI are you using?

@headlessui/react

What version of that package are you using?

2.1.3

What browser are you using?

Chrome

Reproduction URL

https://codesandbox.io/p/devbox/falling-sunset-24wzzr

Describe your issue

  • CloseButtons not closing the popover they are in.
    In the reproduction, press on Products and then, on Insights. The popover should have closed but did not, despite Insights being a CloseButton.

  • PopoverGroup not closing other open popovers they contain.
    In the reproduction, press on Products and then, on Solutions. The popover from Products should have closed but did not, despite being in the same PopoverGroup.

  • Unable to open/close popovers consistently.
    In the reproduction, keep clicking on Products and you'll notice its open/close state does not toggle consistently.

@Dragate Dragate changed the title [2.1.3]: Popover issues [2.1.3]: Popover issues with transition prop Aug 26, 2024
@Dragate
Copy link
Author

Dragate commented Aug 26, 2024

Possible duplicate of #3437

@cod3blox
Copy link

Can confirm the same problems. Compared to 2.1.2, it seeems that the portal of the popup does not get removed on close.

@M4RC0Sx
Copy link

M4RC0Sx commented Sep 1, 2024

Same here

@reinink
Copy link
Member

reinink commented Sep 2, 2024

Hey folks, thanks for reporting this! I am able to reproduce this using a Tailwind UI component (see below). I recommend sticking to 2.1.2 until we've got this figured out 👍

Screen.Recording.2024-09-02.at.11.54.56.AM.mov

@M4RC0Sx
Copy link

M4RC0Sx commented Sep 2, 2024

Hey folks, thanks for reporting this! I am able to reproduce this using a Tailwind UI component (see below). I recommend sticking to 2.1.2 until we've got this figured out 👍

Screen.Recording.2024-09-02.at.11.54.56.AM.mov

Hi! But the issue I opened that happens when you spam-click the button happens on 2.1.2 too. It is not the same issue and I think it should be reopened

@RobinMalfait
Copy link
Member

RobinMalfait commented Sep 3, 2024

Hey sorry about the regression!

This should be fixed by #3448, and will be available in the next release (2.1.4).

You can already try it using:

  • npm install @headlessui/react@insiders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@reinink @RobinMalfait @cod3blox @Dragate @M4RC0Sx and others