-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add single dependency graph view for a specific resource relations #1161
base: develop
Are you sure you want to change the base?
feat: add single dependency graph view for a specific resource relations #1161
Conversation
@shavidze Could you resolve the conflicts before we get to the review |
…at-add-tabs-to-inventory-sidepanel
dashboard/components/inventory/components/InventorySidePanel.tsx
Outdated
Show resolved
Hide resolved
dashboard/components/explorer/dependency-graph/hooks/useDependencyGraph.tsx
Outdated
Show resolved
Hide resolved
dashboard/components/explorer/dependency-graph/hooks/useDependencyGraph.tsx
Show resolved
Hide resolved
…at-add-tabs-to-inventory-sidepanel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The "open in explorer" link doesn't seem like a link, it acts as text on hover.
- IDK if this is intended behaviour but on opening in explorer the filter option is not available.
- On opening in explorer, only the selected resource and it's relations are on the graph. IMO it should have zoomed in on the resource instead of filtering everything else out. But the current one is also good.
you can see our conversation about this feature here |
It seems like point 1 and 3 still stand. |
@Azanul @AllieMendes |
@AllieMendes correct me if I'm wrong. |
hmm, Yes you're right, I'm wrong maybe I read the previous Allie's comment, I will update it today |
Hey @Azanul can we move forward for this PR? |
Hi, sorry I just left to zoom the actual relations on explore page, otherwise the main functionality is done. |
@shavidze no problem. Take all the time you need. Do we know that is still left to be done in this PR? |
….com/shavidze/komiser into feat-add-tabs-to-inventory-sidepanel
….com/shavidze/komiser into feat-add-tabs-to-inventory-sidepanel merge
…at-add-tabs-to-inventory-sidepanel
Thanks for your understanding, and sorry again. |
@Traxmaxx if you got time |
Did you have time to take a look @Traxmaxx ? |
Solution
Add a single dependency graph view for a specific resource relations in the inventory tabs
Checklist
Reviewers
@Traxmaxx