Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a CDK Construct to deploy Komiser helm chart on EKS cluster. #18

Closed
wants to merge 2 commits into from

Conversation

sshiv5768
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ”Œ Chore (Release)
  • ⏩ Revert

Description

Created AWS CDK app that contains komiser construct which helps to deploy the helm chart to AWS EKS cluster.

Related Issues

Refer the issue tailwarden/komiser#897 for more details.

Mobile & Desktop Screenshots/Recordings

Need help, while running cdk deploy it always gives the below error. Although I am using a EKS supported KubernetesVersion by considering the official documentation.

Received response status [FAILED] from custom resource. Message returned: unsupported Kubernetes version 

Screenshot 2023-10-02 at 4 50 16 PM

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.komiser.io
  • πŸ“• storybook
  • πŸ—’ Code comment intelliSense
  • πŸ™… no documentation needed

Complete the checklist before considering this PR as "Ready to review"

  • Pull the Code - Ensure the functionality works locally.
  • Compare to the Design - Check if everything matches the design specifications. Validate the consistency of colors, fonts, paddings, etc.
  • Responsive Testing - Resize the browser window to ensure nothing breaks on mobile
  • Code Quality - Ensure best coding practices are used *
  • Ensure no commented-out code or debug logs are left behind.
  • Check for code modularity and reusability.
  • Check for descriptive variable names: e.g., "totalPrice" not "tp".
  • Ensure there are no linting errors npm run lint
  • Ensure the code passes the build npm run build
  • Ensure there are no inline error disabling/ignores
  • Ensure all newly added dependencies are actually necessary (package.json)
  • Check that the PR has a title and description

@sshiv5768
Copy link
Contributor Author

@mlabouardy need help with this PR.

@AvineshTripathi
Copy link

Hey @sshiv5768 Thanks a million for working on this, can we not use python for this and shift to either golang or typescript cause those are the languages we have been using in komiser.

If you need help with this we can connect and change this to your prefered language. Let me know your thoughts

@Azanul
Copy link
Collaborator

Azanul commented Mar 14, 2024

@mlabouardy need help with this PR.

I've got this to work. Could you give me permission to push to your branch

@Azanul
Copy link
Collaborator

Azanul commented Mar 25, 2024

#19

@Azanul Azanul closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants