Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

feat: added versioning for docs #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

addegbenga
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ”Œ Chore (Release)
  • ⏩ Revert

Description

This pull request introduces versioning to the komiser documentation, ensuring that each major or minor release has its dedicated documentation.

Related Issues

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.komiser.io
  • πŸ“• storybook
  • πŸ—’ Code comment intelliSense
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

None

[optional] What gif best describes this PR or how it makes you feel?

You can use Gif for GitHub extension to generate one

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @addegbenga, absolutely amazing work here πŸ’― Superglad that you worked on this much needed versioning in the documentation aspect! Having the documentation versioned with the project would be really cool and useful to the end-users!

We plan to release this with the v3.1.0 version of komiser! What we would ideally prefer is, in this existing PR, you could add 2 versions:

  • v3.1.0 that includes the changes in this release (you can find here v3.1.0 )
  • <v3.1.0 that has all the changes before this release

And an additional CONTRIBUTING.md in this repo that has a step-by-step information on how 1 can update the docs for the next release!

What do you think of the above plan? Would be glad to hear your thoughts on it! I'm personally really excited to see this go live! All credits to you πŸš€

@addegbenga
Copy link
Contributor Author

Hey @addegbenga, absolutely amazing work here πŸ’― Superglad that you worked on this much needed versioning in the documentation aspect! Having the documentation versioned with the project would be really cool and useful to the end-users!

We plan to release this with the v3.1.0 version of komiser! What we would ideally prefer is, in this existing PR, you could add 2 versions:

* `v3.1.0` that includes the changes in this release (you can find here [v3.1.0](https://github.com/tailwarden/komiser/milestone/27) )

* `<v3.1.0` that has all the changes before this release

And an additional CONTRIBUTING.md in this repo that has a step-by-step information on how 1 can update the docs for the next release!

What do you think of the above plan? Would be glad to hear your thoughts on it! I'm personally really excited to see this go live! All credits to you πŸš€

Hello @ShubhamPalriwala above plan sounds good to me, i will revert as soon as possible.

@ShubhamPalriwala
Copy link
Collaborator

Hey @addegbenga, any updates on this πŸ™ŒπŸΌ ? We are planning to make a release on Komiser in a while 🀞🏼

@addegbenga
Copy link
Contributor Author

addegbenga commented Jul 21, 2023

Hey @addegbenga, any updates on this πŸ™ŒπŸΌ ? We are planning to make a release on Komiser in a while 🀞🏼

Hello @ShubhamPalriwala,
Sorry for the delay I wanted to update you that I've implemented the improvements you suggested in my latest commit. Here's an overview of the changes I made:

Added two versions: v3.0.0 for the previous release and v3.1.0 for the current release. This allows for better version control and easy tracking of changes.

Included a comprehensive contribution guide on how to create a next release and publish it. This will make it easier for other contributors to follow the release process and maintain consistency.

However, I noticed that the docs versions I created are duplicates of one another. how do i make the current release v.3.1.0 docs capture all the changes in this Komiser new release?

@ShubhamPalriwala
Copy link
Collaborator

Hey @addegbenga, thanks for the update! All looks perfect to me πŸš€ ! We just released a v3.1.0, whenever you are ready with the version, just ping me once and we can merge the updated documentation as well! 🀞🏼

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants