cmd/containerboot: don't attempt to write kube Secret in non-kube environments #14358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ironments Updates #14354 Signed-off-by: Irbe Krumina <[email protected]>
tomhjp
reviewed
Dec 11, 2024
tomhjp
approved these changes
Dec 11, 2024
irbekrm
added a commit
that referenced
this pull request
Dec 11, 2024
…ironments (#14358) Updates #14354 Signed-off-by: Irbe Krumina <[email protected]>
irbekrm
added a commit
that referenced
this pull request
Dec 11, 2024
…ironments (#14358) Updates #14354 Signed-off-by: Irbe Krumina <[email protected]> (cherry picked from commit 0cc071f)
irbekrm
added a commit
that referenced
this pull request
Dec 11, 2024
…14358) (#14359) * cmd/containerboot: guard kubeClient against nil dereference (#14357) A method on kc was called unconditionally, even if was not initialized, leading to a nil pointer dereference when TS_SERVE_CONFIG was set outside Kubernetes. Add a guard symmetric with other uses of the kubeClient. Signed-off-by: Bjorn Neergaard <[email protected]> (cherry picked from commit 8b1d011) * cmd/containerboot: don't attempt to write kube Secret in non-kube environments (#14358) Signed-off-by: Irbe Krumina <[email protected]> (cherry picked from commit 0cc071f) * cmd/containerboot: don't attempt to patch a Secret field without permissions (#14365) Signed-off-by: Irbe Krumina <[email protected]> (cherry picked from commit 6e552f6) Updates #14354
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #14357, fixes a second place where the
https_endpointfield was written to the kube Secret without a check + adds some tests that would have caught this.I've tested that non-kube containers work with
TS_SERVE_CONFIGwith this change, i.eUpdates #14354