test(bridge): test TokenVault sendERC20 function #473
Conversation
Codecov Report
@@ Coverage Diff @@
## claimTokens #473 +/- ##
===============================================
+ Coverage 65.91% 67.24% +1.32%
===============================================
Files 109 109
Lines 2940 2940
Branches 355 355
===============================================
+ Hits 1938 1977 +39
+ Misses 926 886 -40
- Partials 76 77 +1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| [bridgedToken.address]: weth, | ||
| }); | ||
|
|
||
| await helpers.setStorageAt(bridgedToken.address, 203, 1000000); |
There was a problem hiding this comment.
If smock.setVariable works, i think we should change all the getSlot and setStorageAt to smock.setVariable in all tests? Since these setStorageAt with a hardcode slot number is really non-trivial to maintain, eveytime anyone changes the contract's code, their tests may fail and u may need to update this 203 or other slots number to a new value manually?
There was a problem hiding this comment.
I can go through and change that, should I make a separate PR or do it for all tests using setStorageAt on this branch?
There was a problem hiding this comment.
Lets make a separate PR that targets to this PR's branch?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
No description provided.