Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(taiko-client): check the blockID of the last verified block before using it as FinalizedBlockHash #18739

Merged
merged 5 commits into from
Jan 9, 2025
Merged

fix(taiko-client): check the blockID of the last verified block before using it as FinalizedBlockHash #18739

merged 5 commits into from
Jan 9, 2025
+16 −27

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Jan 9, 2025 •
edited
Loading

ref:
telegram-cloud-photo-size-5-6053379241615147620-w

Error in taiko-geth:

WARN [01-09|02:00:51.973] Served engine_forkchoiceUpdatedV2        conn=[::1]:51920 reqid=324196 duration=8.170036ms err="Invalid forkchoice state" errdata="{\"err\":\"final block not available in database\"}"

@davidtaikocha davidtaikocha changed the title feat(taiko-client): check the blockID of the last verified block before using it as FinalizedBlockHash feat(taiko-client): check the blockID of the last verified block before using it as FinalizedBlockHash Jan 9, 2025
@davidtaikocha davidtaikocha changed the title feat(taiko-client): check the blockID of the last verified block before using it as FinalizedBlockHash fix(taiko-client): check the blockID of the last verified block before using it as FinalizedBlockHash Jan 9, 2025
@davidtaikocha davidtaikocha enabled auto-merge (squash) January 9, 2025 08:10
@davidtaikocha davidtaikocha merged commit 8c364b1 into main Jan 9, 2025
9 checks passed
@davidtaikocha davidtaikocha deleted the check-last-verified-num branch January 9, 2025 08:18
@taiko-kitty taiko-kitty mentioned this pull request Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mask-pp mask-pp mask-pp approved these changes

@YoGhurt111 YoGhurt111 YoGhurt111 approved these changes

Assignees
No one assigned
Labels
area.client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidtaikocha @YoGhurt111 @mask-pp