chore(protocol): fix issues in test:coverage #18582
Conversation
xiaodino
requested review from
dantaik,
YoGhurt111,
smtmfft and
davidtaikocha
chore(protocol): fix issues in test:coverage
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
packages/protocol/foundry.toml
Outdated
| @@ -67,6 +64,7 @@ test = "test/layer2" | |||
| script = "script/layer2" | |||
| out = "out/layer2" | |||
| evm_version = "shanghai" | |||
| fuzz.runs = 200 | |||
There was a problem hiding this comment.
should we also add this config to other prifiles?
There was a problem hiding this comment.
Updated to
[profile.default]
fuzz_runs = 200
| @@ -98,23 +98,23 @@ contract TestLibEIP1559 is Layer2Test { | |||
| assertEq(baselineBasefee, basefee); | |||
| } | |||
|
|
|||
| /// forge-config: layer2.fuzz.runs = 1000 | |||
| /// forge-config: layer2.fuzz.show-logs = true | |||
| /// forge-config: layer_2.fuzz.runs = 1000 | |||
There was a problem hiding this comment.
forge-config will convert layer2 to layer_2 in *.t.sol files when fuzz.runs is used.
There was a problem hiding this comment.
Updated to forge-config: default.fuzz_runs = 2000
| @@ -98,23 +98,23 @@ contract TestLibEIP1559 is Layer2Test { | |||
| assertEq(baselineBasefee, basefee); | |||
| } | |||
|
|
|||
| /// forge-config: layer2.fuzz.runs = 1000 | |||
| /// forge-config: layer2.fuzz.show-logs = true | |||
| /// forge-config: default.fuzz_runs = 1000 | |||
There was a problem hiding this comment.
I think we should also change layer_2.fuzz_runs to default.fuzz_runs, no?
There was a problem hiding this comment.
Good point. Rename both layer2.fuzz.runs and layer2.fuzz.show-logs to default.fuzz_runs and default.fuzz_runs_show_logs
No description provided.