Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(taiko-client): skip TestCheckL1ReorgToSameHeightFork temporarily #18522

Merged
merged 1 commit into from
Nov 25, 2024
Merged

test(taiko-client): skip TestCheckL1ReorgToSameHeightFork temporarily #18522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/taiko-client/driver/driver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ func (s *DriverTestSuite) TestCheckL1ReorgToLowerFork() {
}

func (s *DriverTestSuite) TestCheckL1ReorgToSameHeightFork() {
s.T().Skip("Skip this test case because of the anvil timestamp issue after rollback.")
var (
testnetL1SnapshotID = s.SetL1Snapshot()
)
Expand Down
5 changes: 0 additions & 5 deletions packages/taiko-client/pkg/rpc/methods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,11 +322,6 @@ func (c *Client) CalculateBaseFee(
return nil, fmt.Errorf("failed to fetch parent gas excess: %w", err)
}
}
// The time of l1Head should always be greater than that of l2Head.
// Since the block.Time after anvil rollback is smaller than the original one, the timestamp has to be modified here.
if currentTimestamp < l2Head.Time {
currentTimestamp = l2Head.Time + 1
}
baseFeeInfo, err = c.TaikoL2.CalculateBaseFee(
&bind.CallOpts{BlockNumber: l2Head.Number, Context: ctx},
*baseFeeConfig,
Expand Down
Loading