Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(protocol): change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000 #18322

Merged
merged 4 commits into from
Oct 28, 2024
Merged

chore(protocol): change Hekla sharingPctg to 80% & gasIssuancePerSecond to 1000000 #18322

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5dfde67
chore(protocol): change Hekla base sharingPctg to 80%
dantaik Oct 28, 2024
a2e9774
Merge branch 'main' into hekla_basefee_share_to_80%
dantaik Oct 28, 2024
40ed33c
Update Lib1559Math.t.sol
dantaik Oct 28, 2024
58906de
Update packages/protocol/contracts/layer1/hekla/HeklaTaikoL1.sol
dantaik Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/protocol/contracts/layer1/hekla/HeklaTaikoL1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ contract HeklaTaikoL1 is TaikoL1 {
maxAnchorHeightOffset: 64,
baseFeeConfig: LibSharedData.BaseFeeConfig({
adjustmentQuotient: 8,
sharingPctg: 75,
sharingPctg: 80,
gasIssuancePerSecond: 5_000_000,
dantaik marked this conversation as resolved.
Show resolved Hide resolved
dantaik marked this conversation as resolved.
Show resolved Hide resolved
minGasExcess: 1_340_000_000,
maxGasIssuancePerBlock: 600_000_000 // two minutes
Expand Down
4 changes: 2 additions & 2 deletions packages/protocol/test/layer2/Lib1559Math.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ contract TestLib1559Math is TaikoL2Test {
console2.log("Mainnet minimal basefee: ", Lib1559Math.basefee(1_340_000_000, 5_000_000 * 8));
}

function test_change_of_quotient_and_gips() public {
function test_change_of_quotient_and_gasIssuancePerSecond() public {
uint64 excess = 150 * 2_000_000;
uint64 target = 4 * 2_000_000;
uint256 unit = 10_000_000; // 0.01 gwei
Expand Down Expand Up @@ -74,7 +74,7 @@ contract TestLib1559Math is TaikoL2Test {
}
}

function test_change_of_quotient_and_gips2() public {
function test_change_of_quotient_and_gasIssuancePerSecond2() public {
uint64 excess = 1;
uint64 target = 60_000_000 * 8;
uint256 unit = 10_000_000; // 0.01 gwei
Expand Down