Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(protocol): avoid installing netcat in action #18159

Merged
merged 4 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/protocol.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- name: Prepare environment
continue-on-error: true
run: sudo apt-get update && sudo apt-get install -y git netcat wget
run: sudo apt-get update && sudo apt-get install -y git wget

- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
timeout-minutes: 2
run: |
anvil --hardfork cancun &
while ! nc -z localhost 8545; do
until cast chain-id --rpc-url "http://localhost:8545" 2> /dev/null; do
sleep 1
done
pnpm test:deploy:l1
Expand Down
19 changes: 4 additions & 15 deletions packages/taiko-client/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,10 @@
run:
timeout: 20m
tests: true
skip-dirs-use-default: true
skip-files:
- bindings/gen_taiko_l1.go
- bindings/gen_taiko_l2.go
- bindings/encoding/struct.go

issues:
# List of regexps of issue texts to exclude.
#
# But independently of this option we use default exclude patterns,
# it can be disabled by `exclude-use-default: false`.
# To list all excluded by default patterns execute `golangci-lint run --help`
#
# Default: https://golangci-lint.run/usage/false-positives/#default-exclusions
exclude:
- abcdef
exclude-dirs:
- bindings

linters:
disable-all: true
Expand All @@ -43,7 +31,8 @@ linters:
- makezero
- misspell
- misspell
- megacheck
- gosimple
- staticcheck
- revive
- staticcheck
- sqlclosecheck
Expand Down
Loading