feat(protocol): reduce gas cost by skipping reading storage for delegates()
#17487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): reduce gas cost by skipping reading storage for
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
2 2 0 8 42 54 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
dantaik
changed the title
delegates()
adaki2004
reviewed
Jun 6, 2024
adaki2004
approved these changes
Jun 6, 2024
davidtaikocha
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you can see from the image above, for everyone TAIKO transfer, this function is always called:
Reading
delegates(from)anddelegates(to)cost 2100 each, which sucks. This PR make suredelegatesalways return 0 for two special address: TaikoL1 and ERC20Vault to reduce gas cost, as these addresses never delegate.A better but my trouble "fix" is to wrap TAIKO into a BOND token which is a pure ERC20 token for bonds.