feat(protocol): add more events in automata #17195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(protocol): add more events in automata
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
dantaik
reviewed
May 15, 2024
| @@ -70,14 +70,22 @@ contract AutomataDcapV3Attestation is IAttestation, EssentialContract { | |||
| pemCertLib = PEMCertChainLib(pemCertLibAddr); | |||
| } | |||
|
|
|||
| event SetMrSigner(bytes32); | |||
There was a problem hiding this comment.
please give variabls name.
There was a problem hiding this comment.
please also run pnpm lint:sol
dantaik
reviewed
May 15, 2024
| event ConfigQeIdentity(bytes32); | ||
| event ToggleLocalReportCheck(bool); | ||
| event AddRevokedCertSerialNum(uint256, bytes); | ||
| event RemoveRevokedCertSerialNum(uint256, bytes); |
There was a problem hiding this comment.
you may also want to add indexed keyword to certain events.
dantaik
reviewed
May 15, 2024
| @@ -92,7 +100,7 @@ contract AutomataDcapV3Attestation is IAttestation, EssentialContract { | |||
| continue; | |||
| } | |||
| serialNumIsRevoked[index][serialNumBatch[i]] = true; | |||
| // TODO(yue): emit an event | |||
| emit AddRevokedCertSerialNum(index, serialNumBatch[i]); | |||
There was a problem hiding this comment.
how about rename addRevokedCertSerialNum to revokeCertSerialNum, then rename event to CertSerialNumRevoked.
I also suggest to rename other events to xxxAdded, xxxRemoved, xxxConfigured, xxxSet
dantaik
merged commit ee37226
into
suggest_changes_in_AutomataDcapV3Attestation
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.