Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix tier ID check issue in GuardianProver.approve() #17170

Merged
merged 2 commits into from
May 14, 2024
Merged

fix(protocol): fix tier ID check issue in GuardianProver.approve() #17170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a458eb
fix(protocol): fix an issue in `GuardianProver.approve`
davidtaikocha May 14, 2024
1eed278
fix
dantaik May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/protocol/contracts/L1/provers/GuardianProver.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ contract GuardianProver is IVerifier, Guardians {
nonReentrant
returns (bool approved_)
{
if (_proof.tier != LibTiers.TIER_GUARDIAN) {
davidtaikocha marked this conversation as resolved.
Show resolved Hide resolved
revert INVALID_PROOF();
}

bytes32 hash = keccak256(abi.encode(_meta, _tran, _proof.data));
approved_ = approve(_meta.id, hash);

Expand Down
1 change: 0 additions & 1 deletion packages/protocol/contracts/L1/provers/Guardians.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ abstract contract Guardians is EssentialContract {
error INVALID_GUARDIAN();
error INVALID_GUARDIAN_SET();
error INVALID_MIN_GUARDIANS();
error INVALID_PROOF();

/// @notice Set the set of guardians
/// @param _newGuardians The new set of guardians
Expand Down