feat(protocol): allow resetting genesis hash on L1 before 1st block is proposed #17078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
commented
May 10, 2024
davidtaikocha
approved these changes
May 10, 2024
feat(protocol): allow resetting genesis hash on L1 before 1st block is proposed
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
adaki2004
approved these changes
May 10, 2024
There was a problem hiding this comment.
I think it makes sense, but only in case if we want to deploy all contracts while still being able to do last minute change - which we should not imo at this point.
My .02: we should have a process for upgrading, and documented. we cannot do these kind of random, rushed merges/changes at mainnet either. We should practice some relax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to reset genesis in TaikoL1 on Ethereum to indirectly upgrade its L2 contracts