Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): add GovernorSettingsUpgradeable #16687

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

adaki2004
Copy link
Contributor

As per OZ finding:

N-09 Changing Governor Parameters Requires an Upgrade

The TaikoGovernor contract is intended to be set as the proposer and executor of the TaikoTimelock contract, which will be set as the owner of the other deployed contracts. Parameters of the TaikoGovernor contracts include the votingDelay, the votingPeriod, and the proposalThreshold.

These parameters are [hardcoded in the contract](https://github.com/taikoxyz/taiko-mono/blob/b47fc34cb0e7fe9b7ebd9416b3051a067483b860/packages/protocol/contracts/L1/gov/TaikoGovernor.sol#L111-L125) and would require a contract upgrade if there was a need to update them.

If such flexibility is desired, consider inheriting from [GovernorSettingsUpgradeable](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable/blob/release-v4.8/contracts/governance/extensions/GovernorSettingsUpgradeable.sol) to allow for these parameters to be changed by governance without having to upgrade the contract.

Copy link

fix(protocol): add GovernorSettingsUpgradeable

Generated at commit: 3a8109c309aabb0843af69e3c749c47bbc090db9

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@dantaik dantaik added this pull request to the merge queue Apr 8, 2024
Merged via the queue into main with commit eba82ba Apr 8, 2024
6 checks passed
@dantaik dantaik deleted the taiko_governor_settings branch April 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants