Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix signature reuse bug #16611

Merged
merged 4 commits into from
Apr 2, 2024
Merged

fix(protocol): fix signature reuse bug #16611

merged 4 commits into from
Apr 2, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Apr 2, 2024

No description provided.

@dantaik dantaik marked this pull request as ready for review April 2, 2024 13:26
@adaki2004
Copy link
Contributor

adaki2004 commented Apr 2, 2024

Well, it is OK, but i dont see any security concern here, because basically it is just a "delegation".

So Bob delegates to Alice to withdran on behalf of him, but with this solution it guards it with a nonce (so one-time delegation) ? Ok, maybe enhanced security, so I'm OK with it.

But if the argument is to fix cross-chain signature replay, then this is not solving it. We should have then block.chainid too.

Copy link

openzeppelin-code bot commented Apr 2, 2024

fix(protocol): fix signature reuse bug

Generated at commit: c2d6475b07d1f85f02d887e07da2f0f41c9b503d

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
2
0
3
39
46
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@Brechtpd Brechtpd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the owner may indeed want to stop using the to address.

@dantaik dantaik added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit ff2dc11 Apr 2, 2024
10 checks passed
@dantaik dantaik deleted the withdrawalNonces branch April 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants