feat(protocol): allow someone to ack message reception then invoke the message before others to earn the fee #15563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Brechtpd
approved these changes
Jan 25, 2024
| @@ -95,8 +95,9 @@ contract Bridge is EssentialContract, IBridge { | |||
| external | |||
| onlyFromNamed("bridge_watchdog") | |||
| { | |||
| uint64 _timestamp = toPause ? type(uint64).max : uint64(block.timestamp); | |||
There was a problem hiding this comment.
I guess have to be a bit careful here because the timestamp is used to do math on, and so if that math is done on uint64s it may overflow. I think currently it's fine because the value is upcasted to uint256s when it's used in math, and also the transactions reverting with overflow is okay for these messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow someone to ack the reception of a message then be the preferred transactor to invoke the transaction before any other addresses (including the message's owner). This solves the fee issue: