-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bridge-ui): mobile issues #13927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13927 +/- ##
=======================================
Coverage 51.78% 51.78%
=======================================
Files 146 146
Lines 3816 3816
Branches 335 336 +1
=======================================
Hits 1976 1976
Misses 1726 1726
Partials 114 114
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…koxyz/taiko-mono into remove_metamask_from_mobiles
jscriptcoder
requested review from
cyberhorsey,
dionysuzx,
dantaik and
davidtaikocha
June 9, 2023 13:14
davidtaikocha
previously approved these changes
Jun 9, 2023
dionysuzx
previously approved these changes
Jun 9, 2023
…koxyz/taiko-mono into remove_metamask_from_mobiles
jscriptcoder
dismissed stale reviews from dionysuzx and davidtaikocha
via
June 9, 2023 13:16
1c8f268
davidtaikocha
approved these changes
Jun 9, 2023
dantaik
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where to test:
https://bridge-ui-a3-git-removemetamaskfrommobiles-taikoxyz.vercel.app/
What's done here:
MetaMask
connector for mobile/tablet devices. Providerethereum
is simply not injected there. Better to useWalletConnect
which will interact with the mobile MetaMaskfetchSigner()
provided bywagmi
to get the signer instead.switchNetwork
new function.