Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bridge-ui): No import.meta workaround needed #13274

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

jscriptcoder
Copy link
Contributor

There is no need for the previous workaround with Vite and import.meta.env vars. The problem is not that Vite isn't able to parse import.meta.env?, the problem is with import.meta?.env.

As for mocking env vars, whenever it's needed, then we could decide to route those env vars through a separate module that we can easily mock.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #13274 (4e06fa5) into main (f9f38bb) will increase coverage by 0.06%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##             main   #13274      +/-   ##
==========================================
+ Coverage   61.55%   61.61%   +0.06%     
==========================================
  Files         119      118       -1     
  Lines        3475     3478       +3     
  Branches      485      491       +6     
==========================================
+ Hits         2139     2143       +4     
+ Misses       1251     1250       -1     
  Partials       85       85              
Flag Coverage Δ *Carryforward flag
bridge-ui 94.52% <96.29%> (+0.32%) ⬆️
protocol 52.37% <ø> (ø) Carriedforward from ed0c218
relayer 64.71% <ø> (ø) Carriedforward from ed0c218
ui 100.00% <ø> (ø) Carriedforward from ed0c218

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/bridge-ui/src/domain/chain.ts 90.24% <96.15%> (+2.36%) ⬆️
packages/bridge-ui/src/domain/token.ts 100.00% <100.00%> (+6.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jscriptcoder jscriptcoder changed the title No import.meta workaround needed chore(bridge-ui): No import.meta workaround needed Mar 8, 2023
@shadab-taiko shadab-taiko added this pull request to the merge queue Mar 8, 2023
Merged via the queue into main with commit 9cb1740 Mar 8, 2023
@shadab-taiko shadab-taiko deleted the no-import-meta-workaround-needed branch March 8, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants