Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bridge-ui): support both bull and horse tokens on the bridge UI #13249

Merged
merged 32 commits into from
Mar 8, 2023
Merged

feat(bridge-ui): support both bull and horse tokens on the bridge UI #13249

merged 32 commits into from
Mar 8, 2023

Conversation

jscriptcoder
Copy link
Contributor

@jscriptcoder jscriptcoder commented Mar 3, 2023 •
edited
Loading

What's done here:

  1. Re-implementation of TEST_ERC20, which creates a list of tokens based on a stringified object coming from env var.
  2. Added support for listing multiple test tokens in SelectToken dropdown from TEST_ERC20.
  3. We no longer check a fixed token, what previously was TEST_ERC20, but the selected one from token store.
  4. Changed wording in FaucetModal informing about the amount of tokens to be minted.
  5. Removed unnecessary BaseQueries component.
  6. Configured prettier.
  7. New env var: VITE_TEST_ERC20: '[{ address, symbol, name }, ...]'
  8. Updated README.md and .default.env file to reflect changes on the env vars.

Screenshot 2023-03-05 at 22 04 03

@jscriptcoder jscriptcoder self-assigned this Mar 3, 2023
@jscriptcoder jscriptcoder linked an issue Mar 3, 2023 that may be closed by this pull request
feat(bridge-ui): support both BULL and HORSE tokens on the bridge-ui #13243
Closed
@jscriptcoder jscriptcoder marked this pull request as draft March 3, 2023 13:02
shadab-taiko
shadab-taiko previously approved these changes Mar 7, 2023
View reviewed changes
@jscriptcoder jscriptcoder force-pushed the 13243-featbridge-ui-support-both-bull-and-horse-tokens-on-the-bridge-ui branch from dbef8d0 to 27ab6b3 Compare March 7, 2023 13:44
@dantaik dantaik enabled auto-merge March 8, 2023 01:32
@dantaik dantaik added this pull request to the merge queue Mar 8, 2023
Merged via the queue into main with commit f9f38bb Mar 8, 2023
@dantaik dantaik deleted the 13243-featbridge-ui-support-both-bull-and-horse-tokens-on-the-bridge-ui branch March 8, 2023 01:40
@github-actions github-actions bot mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberhorsey cyberhorsey cyberhorsey approved these changes

@dantaik dantaik dantaik approved these changes

@shadab-taiko shadab-taiko Awaiting requested review from shadab-taiko

Assignees

@jscriptcoder jscriptcoder

Labels
area.bridge category.enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(bridge-ui): support both BULL and HORSE tokens on the bridge-ui
4 participants
@jscriptcoder @shadab-taiko @dantaik @cyberhorsey