Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): make custom errors in L1 libs a part of the TaikoL1.sol's ABI #13166

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Feb 16, 2023

Like TaikoEvents.sol, clients will need them as a part of the TaikoL1's ABI.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #13166 (ce4dafb) into main (4f7ab64) will increase coverage by 0.15%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main   #13166      +/-   ##
==========================================
+ Coverage   60.95%   61.10%   +0.15%     
==========================================
  Files         115      115              
  Lines        3391     3394       +3     
  Branches      460      463       +3     
==========================================
+ Hits         2067     2074       +7     
+ Misses       1241     1236       -5     
- Partials       83       84       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 6549383
protocol 52.10% <50.00%> (+0.30%) ⬆️
relayer 66.06% <ø> (ø) Carriedforward from 6549383
ui 100.00% <ø> (ø) Carriedforward from 6549383

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 32.69% <ø> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 6.57% <ø> (+0.16%) ⬆️
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.84% <ø> (ø)
packages/protocol/contracts/bridge/EtherVault.sol 76.19% <ø> (ø)
...s/protocol/contracts/bridge/libs/LibBridgeData.sol 100.00% <ø> (ø)
...es/protocol/contracts/test/libs/TestLibProving.sol 0.00% <0.00%> (ø)
...s/protocol/contracts/thirdparty/AddressManager.sol 100.00% <ø> (ø)
...protocol/contracts/thirdparty/ERC20Upgradeable.sol 61.44% <ø> (ø)
packages/protocol/contracts/bridge/TokenVault.sol 51.08% <55.55%> (+0.51%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha marked this pull request as ready for review February 16, 2023 07:51
dantaik
dantaik previously approved these changes Feb 16, 2023
@davidtaikocha davidtaikocha added this pull request to the merge queue Feb 16, 2023
Merged via the queue into main with commit 2943e3e Feb 16, 2023
@davidtaikocha davidtaikocha deleted the TaikoCustomErrors branch February 16, 2023 20:14
@github-actions github-actions bot mentioned this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants