Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): update Yul PlonkVerifier #13133

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

davidtaikocha
Copy link
Member

Update the generated Yul verification contract to match @smtmfft 's latest public input circuits.

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #13133 (7b157a8) into main (95596e4) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13133      +/-   ##
==========================================
+ Coverage   62.57%   62.76%   +0.18%     
==========================================
  Files         114      114              
  Lines        3220     3220              
  Branches      435      435              
==========================================
+ Hits         2015     2021       +6     
+ Misses       1129     1122       -7     
- Partials       76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 95596e4
protocol 53.23% <ø> (+0.34%) ⬆️
relayer 69.15% <ø> (ø) Carriedforward from 95596e4
ui 100.00% <ø> (ø) Carriedforward from 95596e4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha enabled auto-merge (squash) February 10, 2023 05:26
auto-merge was automatically disabled February 10, 2023 05:40

Merge queue setting changed

@davidtaikocha davidtaikocha added this pull request to the merge queue Feb 10, 2023
Merged via the queue into main with commit 5d9b063 Feb 10, 2023
@davidtaikocha davidtaikocha deleted the update-yulp-verifier branch February 10, 2023 05:49
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants