fix(relayer): make sure to return nil for first by msg hash (#13967)

taikoxyz · Jun 12, 2023 · e915fbf · e915fbf
1 parent 0980e57
commit e915fbf
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/relayer/indexer/detect_and_handle_reorg.go b/packages/relayer/indexer/detect_and_handle_reorg.go
@@ -12,7 +12,7 @@ func (svc *Service) detectAndHandleReorg(ctx context.Context, eventType string,
 		return errors.Wrap(err, "svc.eventRepo.FirstByMsgHash")
 	}
 
-	if e == nil {
+	if e == nil || e.MsgHash == "" {
 		return nil
 	}
 

diff --git a/packages/relayer/indexer/save_message_status_changed_events.go b/packages/relayer/indexer/save_message_status_changed_events.go
@@ -63,8 +63,8 @@ func (svc *Service) saveMessageStatusChangedEvent(
 		return errors.Wrap(err, "svc.eventRepo.FirstByMsgHash")
 	}
 
-	if e == nil {
-		return errors.Wrap(err, "svc.eventRepo.FirstByMsgHash")
+	if e == nil || e.MsgHash == "" {
+		return errors.New("message hash doesnt exist when it should")
 	}
 
 	_, err = svc.eventRepo.Save(ctx, relayer.SaveEventOpts{

diff --git a/packages/relayer/repo/event.go b/packages/relayer/repo/event.go
@@ -74,7 +74,7 @@ func (r *EventRepository) FirstByMsgHash(
 	if err := r.db.GormDB().Where("msg_hash = ?", msgHash).
 		First(&e).Error; err != nil {
 		if err == gorm.ErrRecordNotFound {
-			return e, nil
+			return nil, nil
 		}
 
 		return nil, errors.Wrap(err, "r.db.First")