refactor(protocol): optimize signature verification in AssignmentHook (…

…#17486)
taikoxyz · Jun 6, 2024 · cc77898 · cc77898
1 parent 0b1ab18
commit cc77898
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/protocol/contracts/L1/hooks/AssignmentHook.sol b/packages/protocol/contracts/L1/hooks/AssignmentHook.sol
@@ -91,8 +91,16 @@ contract AssignmentHook is EssentialContract, IHook {
             assignment, msg.sender, _meta.sender, _blk.assignedProver, _meta.blobHash
         );
 
-        if (!_blk.assignedProver.isValidSignatureNow(hash, assignment.signature)) {
-            revert HOOK_ASSIGNMENT_INVALID_SIG();
+        if (Address.isContract(_blk.assignedProver)) {
+            if (!_blk.assignedProver.isValidERC1271SignatureNow(hash, assignment.signature)) {
+                revert HOOK_ASSIGNMENT_INVALID_SIG();
+            }
+        } else {
+            (address recovered, ECDSA.RecoverError error) =
+                ECDSA.tryRecover(hash, assignment.signature);
+            if (recovered != _blk.assignedProver || error != ECDSA.RecoverError.NoError) {
+                revert HOOK_ASSIGNMENT_INVALID_SIG();
+            }
         }
 
         // Send the liveness bond to the Taiko contract

diff --git a/packages/protocol/deployments/mainnet-contract-logs-L1.md b/packages/protocol/deployments/mainnet-contract-logs-L1.md
@@ -203,7 +203,7 @@
   - deployed on May 1, 2024 @commit`56dddf2b6`
   - Upgraded from `0x4f664222C3fF6207558A745648B568D095dDA170` to `0xe226fAd08E2f0AE68C32Eb5d8210fFeDB736Fb0d` @commit`b90b932` @tx`0x416560cd96dc75ccffebe889e8d1ab3e08b33f814dc4a2bf7c6f9555071d1f6f`
 - todo:
-  - upgrade assignment hook
+  - upgrade assignment hook again for signature check improvement
 
 #### tier_provider