fix(protocol): address miscellaneous feedbacks from Sigma Prime (TKO2…

…6) (#15600) Co-authored-by: Keszey Dániel <[email protected]> Co-authored-by: Daniel Wang <[email protected]> Co-authored-by: Daniel Wang <[email protected]>
taikoxyz · Jan 30, 2024 · 760d3dc · 760d3dc
1 parent 778ca49
commit 760d3dc
Show file tree

Hide file tree

Showing 20 changed files with 54 additions and 498 deletions.
diff --git a/packages/protocol/contracts/L1/TaikoErrors.sol b/packages/protocol/contracts/L1/TaikoErrors.sol
@@ -27,10 +27,8 @@ abstract contract TaikoErrors {
     error L1_BLOB_FOR_DA_DISABLED();
     error L1_BLOB_NOT_FOUND();
     error L1_BLOB_NOT_REUSEABLE();
+    error L1_BLOB_NOT_USED();
     error L1_BLOCK_MISMATCH();
-    error L1_INSUFFICIENT_TOKEN();
-    error L1_INVALID_ADDRESS();
-    error L1_INVALID_AMOUNT();
     error L1_INVALID_BLOCK_ID();
     error L1_INVALID_CONFIG();
     error L1_INVALID_ETH_DEPOSIT();
@@ -46,12 +44,12 @@ abstract contract TaikoErrors {
     error L1_PROPOSER_NOT_EOA();
     error L1_PROVING_PAUSED();
     error L1_RECEIVE_DISABLED();
+    error L1_MISSING_VERIFIER();
     error L1_TOO_MANY_BLOCKS();
     error L1_TOO_MANY_TIERS();
     error L1_TRANSITION_ID_ZERO();
     error L1_TRANSITION_NOT_FOUND();
-    error L1_TXLIST_OFFSET_SIZE();
-    error L1_TXLIST_TOO_LARGE();
+    error L1_TXLIST_SIZE();
     error L1_UNAUTHORIZED();
     error L1_UNEXPECTED_PARENT();
     error L1_UNEXPECTED_TRANSITION_ID();

diff --git a/packages/protocol/contracts/L1/TaikoEvents.sol b/packages/protocol/contracts/L1/TaikoEvents.sol
@@ -84,18 +84,4 @@ abstract contract TaikoEvents {
     /// @param deposit The Ethereum deposit information including recipient,
     /// amount, and ID.
     event EthDeposited(TaikoData.EthDeposit deposit);
-
-    /// @dev Emitted when a user deposited Taiko token into this contract.
-    event TokenDeposited(uint256 amount);
-
-    /// @dev Emitted when a user withdrawed Taiko token from this contract.
-    event TokenWithdrawn(uint256 amount);
-
-    /// @dev Emitted when Taiko token are credited to the user's in-protocol
-    /// balance.
-    event TokenCredited(address to, uint256 amount);
-
-    /// @dev Emitted when Taiko token are debited from the user's in-protocol
-    /// balance.
-    event TokenDebited(address from, uint256 amount);
 }
diff --git a/packages/protocol/contracts/L1/TaikoL1.sol b/packages/protocol/contracts/L1/TaikoL1.sol
@@ -17,7 +17,7 @@ pragma solidity 0.8.24;
 import "../common/EssentialContract.sol";
 import "./libs/LibDepositing.sol";
 import "./libs/LibProposing.sol";
-// import "./libs/LibProving.sol";
+//import "./libs/LibProving.sol";
 import { LibProvingAlt as LibProving } from "./libs/LibProvingAlt.sol";
 import "./libs/LibVerifying.sol";
 import "./ITaikoL1.sol";