Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

feat(client): remove ChainID api #563

Merged
merged 3 commits into from
Feb 23, 2024
Merged

feat(client): remove ChainID api #563

merged 3 commits into from
Feb 23, 2024

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented Feb 22, 2024

No description provided.

@mask-pp mask-pp requested review from davidtaikocha and cyberhorsey and removed request for davidtaikocha February 22, 2024 13:01
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 52.99%. Comparing base (bacedb0) to head (8ca008f).

Files Patch % Lines
pkg/rpc/ethclient.go 62.50% 2 Missing and 1 partial ⚠️
proposer/proposer.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   52.99%   52.99%           
=======================================
  Files          45       45           
  Lines        5767     5755   -12     
=======================================
- Hits         3056     3050    -6     
+ Misses       2376     2372    -4     
+ Partials      335      333    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mask-pp mask-pp enabled auto-merge (squash) February 23, 2024 03:41
@davidtaikocha davidtaikocha enabled auto-merge (squash) February 23, 2024 05:06
@davidtaikocha davidtaikocha merged commit f5d1146 into main Feb 23, 2024
4 checks passed
@davidtaikocha davidtaikocha deleted the upgrate_client branch February 23, 2024 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants