This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat(proposer): Improved shuffle function to preserve original prover endpoints slice #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request enhances the shuffleProverEndpoints function in the ETHFeeEOASelector struct to return a shuffled slice without modifying the original proverEndpoints slice. The function now operates on a copy of the original slice, shuffles it internally, and returns the shuffled slice without altering the original data.
airdrop-monster
changed the title
davidtaikocha
approved these changes
Dec 22, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
==========================================
+ Coverage 57.90% 58.11% +0.21%
==========================================
Files 44 44
Lines 5516 5520 +4
==========================================
+ Hits 3194 3208 +14
+ Misses 2001 1993 -8
+ Partials 321 319 -2 ☔ View full report in Codecov by Sentry. |
|
Looks like there is a lint error, could u fix it? |
auto-merge was automatically disabled
December 22, 2023 08:33
Head branch was pushed to by a user without write access
|
I couldn't see details about the lint error. It seemed to be giving a goimports error on an empty line. I deleted the empty line; can we try again? I don't want to miss the details this time. @davidtaikocha @cyberhorsey |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the 'shuffleProverEndpoints' function in the 'ETHFeeEOASelector' struct to return a shuffled slice without modifying the original 'proverEndpoints' slice. The function now operates on a copy of the original slice, shuffles it internally, and returns the shuffled slice without altering the original data.