Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

fix(all): fix missing logs should be print in stderr #370

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

alexshliu
Copy link
Contributor

Reason for this bug: root logger uses DiscardHandler by default and logs will be ignored.

@alexshliu alexshliu self-assigned this Aug 28, 2023
@alexshliu alexshliu marked this pull request as ready for review August 28, 2023 14:34
Base automatically changed from a5-tokenomics to main August 29, 2023 05:06
@alexshliu alexshliu marked this pull request as draft August 29, 2023 06:17
@taikoxyz taikoxyz deleted a comment from codecov bot Aug 29, 2023
@alexshliu alexshliu marked this pull request as ready for review August 29, 2023 06:32
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #370 (d482532) into main (e09fd97) will decrease coverage by 0.34%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   55.18%   54.84%   -0.34%     
==========================================
  Files          38       38              
  Lines        4764     4768       +4     
==========================================
- Hits         2629     2615      -14     
- Misses       1873     1891      +18     
  Partials      262      262              
Files Changed Coverage Δ
prover/prover.go 38.00% <100.00%> (-2.35%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidtaikocha davidtaikocha self-requested a review August 29, 2023 12:50
@alexshliu alexshliu merged commit af6531b into main Aug 31, 2023
@alexshliu alexshliu deleted the fix/miss-log branch August 31, 2023 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants