Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: complete v3 Aggregation APIs #424

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: complete v3 Aggregation APIs #424

wants to merge 3 commits into from

Commits on Nov 29, 2024

  1. feat(host): complete the aggregation API

    @petarvujovic98 @keroro520
    petarvujovic98 authored and keroro520 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    552f9ca View commit details
    Browse the repository at this point in the history

  2. feat(tasks): complete aggregation task APIs 

    Write in-memory implementation
Stub out sqlite implementation
    @petarvujovic98 @keroro520
    petarvujovic98 authored and keroro520 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    03585bb View commit details
    Browse the repository at this point in the history

  3. feat(host): update v3 Aggregation Cancel API 

    All of theses changes were commentted and discussed at taikoxyz#387

1. Remove checking of empty proof of Aggregation Cancel request.

  For this case, querying task status will return None, and we will
response with NotFound error directly. See also taikoxyz#387 (comment)

2. Remove metrics recording to maintain consistency with v1 and v2

  See also taikoxyz#387 (comment)

3. Check task status before signal cancel to prover
    @keroro520
    keroro520 committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    fb72f3b View commit details
    Browse the repository at this point in the history