Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move ProofType into raiko_lib #421

Merged
merged 4 commits into from
Nov 28, 2024

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Nov 25, 2024

The ProofType is a primitive component within Raiko. However, currently, there is some redundancy and confusion with similar items. I intend to refactor ProofType for clarity and independence as follows:

  1. Move ProofType to raiko_lib, to ensure that ProofType be indenpendent with other items

  2. Merge Proof System ID into ProofType, to eliminate redundant definitions and simplify the management of proof types for taskdb

  3. Merge VerifierType into ProofType.

This pull request focuses on the first step: moving ProofType into raiko_lib and making it independent of other constructs. In fact, this pull request is more easy than it looks like, and it doesn't introduce any new changes:

  • fe5d48a moves the ProofType definition into raiko-lib
  • 33c88d9 adjust some relevant code

@keroro520 keroro520 force-pushed the refactor-mv-ProofType-into-lib branch from 7b374f1 to 33c88d9 Compare November 26, 2024 02:32
@keroro520 keroro520 force-pushed the refactor-mv-ProofType-into-lib branch from 1279b2f to b592382 Compare November 26, 2024 08:49
lib/src/proof.rs Outdated Show resolved Hide resolved
taskdb/src/lib.rs Show resolved Hide resolved
@keroro520 keroro520 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into taikoxyz:main with commit 4045da8 Nov 28, 2024
14 checks passed
@keroro520 keroro520 deleted the refactor-mv-ProofType-into-lib branch November 28, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants