chore: remove redundant and implicit From impl #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keroro520
force-pushed
the
chore-remove-reduandent-and-implicit-from-impl
branch
from
1141221 to
801a6b8
Compare
keroro520
temporarily deployed
to
test-environment
GitHub Actions
Inactive
smtmfft
approved these changes
Nov 22, 2024
keroro520
force-pushed
the
chore-remove-reduandent-and-implicit-from-impl
branch
from
801a6b8 to
3edae57
Compare
keroro520
force-pushed
the
chore-remove-reduandent-and-implicit-from-impl
branch
from
3edae57 to
1ee5fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several implicit From implementations, which made type transformations implicit and not easy to understand without providing any benefits.