-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow naming the projected types #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
naming
branch
2 times, most recently
from
May 7, 2020 02:59
5d6a07f
to
e875c5a
Compare
bors bot
added a commit
that referenced
this pull request
May 7, 2020
211: Hide generated items from --document-private-items r=taiki-e a=taiki-e All of the generated items are private items, but it can be displayed in the document by using the `--document-private-items` flag. Naming will be allowed by #202, so it would probably be preferable to only display it in the document if the user did a naming. cc #124 #202 Related: #192 Co-authored-by: Taiki Endo <[email protected]>
taiki-e
force-pushed
the
naming
branch
12 times, most recently
from
May 8, 2020 12:54
fb617bf
to
2e1e542
Compare
Merged
taiki-e
force-pushed
the
naming
branch
2 times, most recently
from
May 8, 2020 13:06
0fab113
to
bb40a68
Compare
bors bot
added a commit
that referenced
this pull request
May 8, 2020
214: Various cleanup r=taiki-e a=taiki-e Separated from #202 as unrelated changes. Co-authored-by: Taiki Endo <[email protected]>
taiki-e
force-pushed
the
naming
branch
6 times, most recently
from
May 8, 2020 22:37
0442575
to
7657fde
Compare
Merged
bors bot
added a commit
that referenced
this pull request
May 9, 2020
219: Implement !Unpin option r=taiki-e a=taiki-e ## Example ```rust #[pin_project(!Unpin)] struct Struct<T, U> { #[pin] pinned: T, unpinned: U, } ``` Also, bump MSRV to 1.34 because `unrestricted_attribute_tokens` requires 1.34 (#202 also requires 1.34). Closes #108 Co-authored-by: Taiki Endo <[email protected]>
taiki-e
force-pushed
the
naming
branch
3 times, most recently
from
May 10, 2020 16:55
07754b7
to
fe90f03
Compare
taiki-e
force-pushed
the
naming
branch
2 times, most recently
from
May 18, 2020 12:00
ae3caf7
to
ac0f614
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing an argument with the same name as the method to the attribute, you can name the projection type returned from the method:
cc #43
Closes #124
TODO:
unrestricted_attribute_tokens
requires 1.34); done in Implement !Unpin option #219