Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy lifetime to UnpinStruct #111

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Add a dummy lifetime to UnpinStruct #111

merged 1 commit into from
Sep 26, 2019

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Sep 26, 2019

Basically the same as #107.

This fixes #102 completely.

cc #108

@taiki-e taiki-e added the A-unpin Area: Unpin and UnsafeUnpin label Sep 26, 2019
@taiki-e
Copy link
Owner Author

taiki-e commented Sep 26, 2019

bors r+

bors bot added a commit that referenced this pull request Sep 26, 2019
111: Add a dummy lifetime to UnpinStruct r=taiki-e a=taiki-e

Basically the same as #107.

This fixes #102 completely.

cc #108


Co-authored-by: Taiki Endo <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 26, 2019

Build failed

  • taiki-e.pin-project

@taiki-e
Copy link
Owner Author

taiki-e commented Sep 26, 2019

bors retry

bors bot added a commit that referenced this pull request Sep 26, 2019
111: Add a dummy lifetime to UnpinStruct r=taiki-e a=taiki-e

Basically the same as #107.

This fixes #102 completely.

cc #108


Co-authored-by: Taiki Endo <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 26, 2019

Build succeeded

  • taiki-e.pin-project

@bors bors bot merged commit 9d0e875 into master Sep 26, 2019
@taiki-e taiki-e deleted the trivial_bounds branch September 26, 2019 11:01
@RalfJung
Copy link
Contributor

RalfJung commented Oct 8, 2019

This clearly does something complicated and subtle, but I have no idea what and how. :)

Could the code (in the repo) be augmented with a detailed but explanation of what the generated code looks like and why all these funny quirks are needed, and why they are enough? As it is right now, a review of this crate seems near impossible.

@taiki-e
Copy link
Owner Author

taiki-e commented Oct 10, 2019

@RalfJung Oh, sorry. I thought I added comments in #107, but it seems that I actually forgot. I will add it later.

(Also, I left a comment in #102 (comment) about what this PR is doing.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-unpin Area: Unpin and UnsafeUnpin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__UnpinStruct is restricting the pinned field.
2 participants