Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add codecov json format (support region testing) #249

Merged
merged 3 commits into from
Apr 2, 2023
Merged

add codecov json format (support region testing) #249

merged 3 commits into from
Apr 2, 2023

Conversation

andrewgazelka
Copy link
Contributor

@andrewgazelka andrewgazelka commented Mar 30, 2023 •
edited
Loading

Fixes #20

@andrewgazelka andrewgazelka mentioned this pull request Mar 30, 2023
Closed
taiki-e
taiki-e requested changes Mar 30, 2023
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewgazelka andrewgazelka force-pushed the region-coverage-codecov branch 3 times, most recently from 900dc24 to f6d4b45 Compare March 31, 2023 01:00
@andrewgazelka
Copy link
Contributor Author

andrewgazelka commented Mar 31, 2023 •
edited
Loading

Does this look good?

cargo-llvm-cov/tests/fixtures/coverage-reports/real1/all.codecov.json

Lines 1 to 48 in ed1cb3a

{
"coverage": {
"member1/member2/src/lib.rs": {
"1": "2/3",
"2": "1/2",
"3": "1/2",
"4": "0/2",
"5": "0/2",
"6": "0/2",
"8": "1/2"
},
"member1/src/lib.rs": {
"1": "2/3",
"2": "1/2",
"3": "1/2",
"4": "0/2",
"5": "0/2",
"6": "0/2",
"8": "1/2"
},
"src/lib.rs": {
"1": "1/1",
"11": "1/1",
"13": "1/1",
"14": "1/1",
"15": "1/1",
"16": "1/1",
"17": "1/1",
"18": "1/1",
"19": "1/1",
"4": "1/1",
"5": "1/1",
"6": "0/1",
"7": "1/1",
"8": "0/1",
"9": "1/1"
},
"src/tests/mod.rs": {
"10": "1/1",
"11": "1/1",
"12": "1/1",
"13": "1/1",
"14": "1/1",
"15": "1/1",
"9": "1/1"
}
}
}

@andrewgazelka andrewgazelka marked this pull request as ready for review March 31, 2023 01:55
@andrewgazelka andrewgazelka force-pushed the region-coverage-codecov branch from ed1cb3a to 60c9ddc Compare March 31, 2023 01:55
@andrewgazelka andrewgazelka changed the title add codecov json format add codecov json format (support region testing) Mar 31, 2023
@andrewgazelka andrewgazelka force-pushed the region-coverage-codecov branch from 60c9ddc to 06e8a0f Compare March 31, 2023 02:27
@andrewgazelka
Copy link
Contributor Author

andrewgazelka commented Mar 31, 2023 •
edited
Loading

Looks like it works (at least somewhat?) Tested it on a project of mine

@andrewgazelka andrewgazelka force-pushed the region-coverage-codecov branch from ee24a6e to 1ad2967 Compare March 31, 2023 05:49
@andrewgazelka
Copy link
Contributor Author

also it works much better when testing in release mode

@andrewgazelka andrewgazelka force-pushed the region-coverage-codecov branch from 1ad2967 to ce68b44 Compare March 31, 2023 17:28
@andrewgazelka
Copy link
Contributor Author

andrewgazelka commented Mar 31, 2023 •
edited
Loading

@taiki-e I rebased :)

also updates:

  • sorted by line number
  • outputs non-pretty JSON

taiki-e
taiki-e reviewed Apr 1, 2023
View reviewed changes
taiki-e
taiki-e approved these changes Apr 2, 2023
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@taiki-e taiki-e merged commit 63b0201 into taiki-e:main Apr 2, 2023
@andrewgazelka andrewgazelka deleted the region-coverage-codecov branch April 2, 2023 20:10
@taiki-e
Copy link
Owner

taiki-e commented Apr 2, 2023

Published in 0.5.12.

@andrewgazelka andrewgazelka mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support region coverage on codecov
2 participants
@andrewgazelka @taiki-e