Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --include-deps-features #70

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Add --include-deps-features #70

merged 2 commits into from
Oct 19, 2020

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Oct 18, 2020 •
edited
Loading

Closes #29

$ cargo run -- hack check --each-feature --include-deps-features
info: running `cargo check` on cargo-hack (1/15)
...
info: running `cargo check --no-default-features` on cargo-hack (2/15)
...
info: running `cargo check --no-default-features --features ctrlc/termination` on cargo-hack (3/15)
...
info: running `cargo check --no-default-features --features serde_json/alloc` on cargo-hack (4/15)
...

@taiki-e taiki-e added C-enhancement Category: A new feature or an improvement for an existing one A-features Area: features (--feature-powerset, --each-feature, etc.) labels Oct 18, 2020
@taiki-e taiki-e force-pushed the include-deps-features branch 8 times, most recently from a732e5e to fee5095 Compare October 19, 2020 03:43
taiki-e
taiki-e commented Oct 19, 2020
View reviewed changes
src/main.rs Outdated
Comment on lines 136 to 137
// ignore if features already enabled on the crate
if !dep_node.features.contains(f) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this seems not good. IIUC, as resolve.nodes[].features is based on the feature flags when cargo metadata was run, it includes default features and features enabled by dev-dependencies...

@taiki-e taiki-e force-pushed the include-deps-features branch 2 times, most recently from b0406f1 to 7a1ec57 Compare October 19, 2020 04:19
@taiki-e taiki-e force-pushed the include-deps-features branch from 7a1ec57 to 66b9fe1 Compare October 19, 2020 04:40
@taiki-e taiki-e force-pushed the include-deps-features branch from 66b9fe1 to e6f2908 Compare October 19, 2020 04:44
@taiki-e
Copy link
Owner Author

taiki-e commented Oct 19, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 19, 2020

Build succeeded:

@bors bors bot merged commit 3fa63e8 into master Oct 19, 2020
@bors bors bot deleted the include-deps-features branch October 19, 2020 05:27
@taiki-e taiki-e mentioned this pull request Oct 21, 2020
Closed
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: option to also enumerate second-order features
1 participant
@taiki-e