Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ignore-unknown-features + group-features #240

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Implement ignore-unknown-features + group-features #240

merged 3 commits into from
Mar 6, 2024

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Mar 5, 2024 •
edited by taiki-e
Loading

Fixes #161

@taiki-e
Copy link
Owner

taiki-e commented Mar 5, 2024 •
edited
Loading

Thanks!

Could you add a test case to ignore_unknown_features test and update error messages in ignore_unknown_features_failure test?

taiki-e
taiki-e approved these changes Mar 6, 2024
View reviewed changes
Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit 55136c4 into taiki-e:main Mar 6, 2024
27 checks passed
@kornelski kornelski deleted the group-ignore branch March 6, 2024 15:41
@taiki-e
Copy link
Owner

taiki-e commented Mar 6, 2024

Published in 0.6.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo hack ... --features X requires feature X on all workspace crates
2 participants
@kornelski @taiki-e