Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea: add flag to test all feature flag permutation w/ a max # of simultaneous feature flags #58

Closed
carllerche opened this issue Oct 10, 2020 · 1 comment · Fixed by #59
Closed

Idea: add flag to test all feature flag permutation w/ a max # of simultaneous feature flags #58

carllerche opened this issue Oct 10, 2020 · 1 comment · Fixed by #59
Assignees
@taiki-e
Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-enhancement Category: A new feature or an improvement for an existing one

Comments

@carllerche
Copy link

maybe --feature-powerset --depth 2.

Tokio has too many features to test the power set. However, most issues can be reproduced by testing at most 2 features simultaneously. It would be nice to have a feature that tested all permutations of at most N simultaneous feature flags. This would catch most problems.
@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Oct 10, 2020
@taiki-e taiki-e self-assigned this Oct 10, 2020
@taiki-e taiki-e added the A-features Area: features (--feature-powerset, --each-feature, etc.) label Oct 10, 2020
@taiki-e taiki-e mentioned this issue Oct 10, 2020
Merged
@bors bors bot closed this as completed in #59 Oct 10, 2020
@bors bors bot closed this as completed in aff0e62 Oct 10, 2020
@taiki-e
Copy link
Owner

taiki-e commented Oct 10, 2020

Added in cargo-hack 0.3.14 (#59).

@taiki-e taiki-e mentioned this issue Nov 13, 2020
Merged
This was referenced Dec 1, 2020
Closed
Merged
This was referenced Feb 6, 2021
Merged
Merged
Open
@taiki-e taiki-e mentioned this issue Feb 14, 2021
Closed
@taiki-e taiki-e mentioned this issue Jul 20, 2022
Closed
@taiki-e taiki-e mentioned this issue Sep 13, 2022
Merged
carllerche pushed a commit to tokio-rs/tokio that referenced this issue Sep 13, 2022
@taiki-e
ci: use --feature-powerset --depth 2 in features check (#5007)
b891714 
As has been pointed out a few times in the past (e.g., #4036 (comment)), each-feature 
is not sufficient for features check.

Ideally, we'd like to check all combinations of features, but there are too many
combinations. So limit the max number of simultaneous feature flags to 2 by --depth
option. I think this should be sufficient in most cases as @carllerche said in
taiki-e/cargo-hack#58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
A-features Area: features (--feature-powerset, --each-feature, etc.) C-enhancement Category: A new feature or an improvement for an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --depth option to --feature-powerset taiki-e/cargo-hack
2 participants
@carllerche @taiki-e