Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excluding a feature present on only some crates in a workspace displays warning #157

Closed
leighmcculloch opened this issue Jul 25, 2022 · 2 comments · Fixed by #158
Closed

Excluding a feature present on only some crates in a workspace displays warning #157

leighmcculloch opened this issue Jul 25, 2022 · 2 comments · Fixed by #158
Labels
C-bug Category: related to a bug.

Comments

@leighmcculloch
Copy link

Excluding a feature that is not on all crates in a workspace displays warning for each crate that doesn't have the feature.

For example, in the following repo the feature docs is defined on the stellar-contract-sdk crate, but no others. When excluding the feature a warning displays for all other repos:

$ git clone https://github.com/stellar/rs-stellar-contract-sdk
$ cd rs-stellar-contract-sdk
$ git checkout 9481010ac820ce3694d5853db79beee38e302690
$ cargo hack --feature-powerset --exclude-features docs test
warning: specified feature `docs` not found in package `example_add_i32`
warning: specified feature `docs` not found in package `example_add_i64`
warning: specified feature `docs` not found in package `example_udt`
warning: specified feature `docs` not found in package `example_contract_data`
warning: specified feature `docs` not found in package `example_create_contract`
warning: specified feature `docs` not found in package `example_linear_memory`
...
@taiki-e taiki-e added the C-bug Category: related to a bug. label Jul 30, 2022
@taiki-e taiki-e mentioned this issue Jul 30, 2022
Merged
bors bot added a commit that referenced this issue Jul 30, 2022
@bors @taiki-e
Merge #158
6b9edb3 
158: Do not emit warning when excluding feature that exists only in some crates in workspace r=taiki-e a=taiki-e

Fixes #157

Co-authored-by: Taiki Endo <[email protected]>
@bors bors bot closed this as completed in ec14dc0 Jul 30, 2022
@taiki-e
Copy link
Owner

taiki-e commented Jul 30, 2022

Thanks! Addressed in 0.5.16.

@leighmcculloch
Copy link
Author

Thanks for fixing! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not emit "specified feature not found" warning when building multiple packages taiki-e/cargo-hack
2 participants
@leighmcculloch @taiki-e