Merge #101

101: Stop distributing binaries containing version numbers r=taiki-e a=taiki-e See #91 for more. Co-authored-by: Taiki Endo <[email protected]>
taiki-e · Dec 3, 2020 · 07bcd8d · 07bcd8d
2 parents faab7d1 + 8c1e394
commit 07bcd8d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@ This project adheres to [Semantic Versioning](https://semver.org).
 
 * Diagnostic improvements.
 
+* GitHub Releases binaries containing version numbers are no longer distributed. See [#91](https://github.com/taiki-e/cargo-hack/pull/91) for more.
+
 ## [0.4.8] - 2020-12-03
 
 * [Fix an issue that feature combinations exclusion does not work properly when used with `--group-features`.](https://github.com/taiki-e/cargo-hack/pull/99)

diff --git a/ci/upload-assets.sh b/ci/upload-assets.sh
@@ -39,19 +39,11 @@ case "${OSTYPE}" in
   linux* | darwin*)
     strip "${PACKAGE}"
     tar czf ../../"${assets[0]}" "${PACKAGE}"
-    # TODO: remove this when release the next major version.
-    if [[ ${target} != "x86_64-unknown-linux-musl" ]]; then
-      assets+=("${PACKAGE}-${tag}-${target}.tar.gz")
-      tar czf ../../"${assets[1]}" "${PACKAGE}"
-    fi
     ;;
   cygwin* | msys*)
     assets+=("${PACKAGE}-${target}.zip")
     tar czf ../../"${assets[0]}" "${PACKAGE}".exe
     7z a ../../"${assets[1]}" "${PACKAGE}".exe
-    # TODO: remove this when release the next major version.
-    assets+=("${PACKAGE}-${tag}-${target}.zip")
-    7z a ../../"${assets[2]}" "${PACKAGE}".exe
     ;;
   *)
     error "unrecognized OSTYPE: ${OSTYPE}"