Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legacy): InputTime & InputDateTime should switch inputMode for time modes with AM / PM #9643

Merged
merged 3 commits into from
Nov 2, 2024
Merged

fix(legacy): InputTime & InputDateTime should switch inputMode for time modes with AM / PM #9643

merged 3 commits into from
Nov 2, 2024

Conversation

nsbarsukov
Copy link
Member

No description provided.

@nsbarsukov nsbarsukov self-assigned this Oct 30, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 30, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 53aad5e):

https://taiga-previews--pr9643-input-time-mobile-ke-uqpmmr4h.web.app

(expires Sat, 02 Nov 2024 14:20:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Oct 30, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 298.63KB (+182B +0.06%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 259.74KB +10%
✅ demo/browser/runtime.(hash).js
 43.41KB +10%
✅ demo/browser/styles.(hash).css
 19.61KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +184B +0.03%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.23MB (+184B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@nsbarsukov nsbarsukov marked this pull request as ready for review October 30, 2024 14:24
@nsbarsukov nsbarsukov requested a review from a team as a code owner October 30, 2024 14:24
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team October 30, 2024 14:24
@nsbarsukov nsbarsukov merged commit ee53428 into main Nov 2, 2024
26 checks passed
@nsbarsukov nsbarsukov deleted the input-time-mobile-keyboard branch November 2, 2024 08:01
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 5, 2024
Merged
shiv9604 pushed a commit to shiv9604/taiga-ui that referenced this pull request Nov 22, 2024
@nsbarsukov @shiv9604
fix(legacy): InputTime & InputDateTime should switch inputMode …
535f2c9 
…for time modes with AM / PM (taiga-family#9643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsbarsukov @vladimirpotekhin @mdlufy