Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): support : inside path segment in url #9549

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

splincode
Copy link
Member

Fixes #9521

@splincode splincode requested a review from a team as a code owner October 18, 2024 20:37
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team October 18, 2024 20:37
Copy link

lumberjack-bot bot commented Oct 18, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit 029d7e1):

https://taiga-previews--pr9549-splincode-fix-issues-a3dde1y2.web.app

(expires Sat, 19 Oct 2024 20:42:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 18, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
295.88KB +10%
demo/browser/vendor.(hash).js
255.66KB +10%
demo/browser/runtime.(hash).js
43.22KB +10%
demo/browser/styles.(hash).css
19.31KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.16MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea merged commit 8317b67 into main Oct 21, 2024
29 checks passed
@waterplea waterplea deleted the splincode/fix/issues/9521 branch October 21, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Improve checking in function tuiIsValidUrl
4 participants