Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Dropdown triggers change detection too frequently #8738

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

nsbarsukov
Copy link
Member

Previous behavior

before.mov

New behavior

after.mov

Close #8725

@nsbarsukov nsbarsukov self-assigned this Aug 29, 2024
@github-actions github-actions bot added the v4 4.0 candidate label Aug 29, 2024
Copy link

lumberjack-bot bot commented Aug 29, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 29, 2024

Visit the preview URL for this PR (updated for commit f54def4):

https://taiga-previews--pr8738-dropdown-cd-optimiza-z65ay95k.web.app

(expires Fri, 30 Aug 2024 09:23:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Aug 29, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
282.3KB (+94B +0.03%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.4KB +10%
demo/browser/runtime.(hash).js
42KB +10%
demo/browser/styles.(hash).css
11.6KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +96B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.9MB (+79B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

projects/core/directives/dropdown/dropdown.directive.ts Outdated Show resolved Hide resolved
projects/cdk/observables/zone.ts Outdated Show resolved Hide resolved
@splincode splincode merged commit 8bdcb19 into main Aug 29, 2024
28 checks passed
@splincode splincode deleted the dropdown-cd-optimization branch August 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🐞 - Dropdown triggers change detection too frequently
3 participants