Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-editor): allow paste base64 image #3138

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

splincode
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows Conventional Commits
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Code style update
  • Build or CI related changes
  • Documentation content changes

What is the current behavior?

Closes #3096

What is the new behavior?

image

@lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 29, 2022

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@bundlemon
Copy link

bundlemon bot commented Nov 29, 2022

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
326.47KB +10%
demo/browser/vendor.(hash).js
205.35KB +10%
demo/browser/runtime.(hash).js
34.33KB +10%
demo/browser/polyfills.(hash).js
19.92KB +10%
demo/browser/scripts.(hash).js
14.92KB +10%

Total files change +1B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.19MB (+1.03KB +0.05%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

Visit the preview URL for this PR (updated for commit a12cd28):

https://taiga-ui--pr3138-splincode-fix-issues-uvwkh7ow.web.app

(expires Wed, 30 Nov 2022 13:09:33 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 61.68% // Head: 61.67% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a12cd28) compared to base (1d78810).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3138      +/-   ##
==========================================
- Coverage   61.68%   61.67%   -0.01%     
==========================================
  Files        1505     1505              
  Lines       17791    17795       +4     
  Branches     2433     2476      +43     
==========================================
+ Hits        10974    10975       +1     
- Misses       6368     6370       +2     
- Partials      449      450       +1     
Flag Coverage Δ
addon-charts 72.44% <ø> (ø)
addon-doc 48.40% <ø> (ø)
addon-editor 51.23% <50.00%> (-0.01%) ⬇️
addon-mobile 62.31% <ø> (ø)
addon-table 63.91% <ø> (ø)
addon-tablebars 98.07% <ø> (ø)
cdk 40.36% <ø> (-0.02%) ⬇️
core 76.77% <ø> (ø)
kit 73.41% <ø> (ø)
summary 61.67% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../extensions/image-editor/image-editor.component.ts 37.03% <40.00%> (+1.03%) ⬆️
...ult-editor-extensions/default-editor-extensions.ts 100.00% <100.00%> (ø)
projects/cdk/schematics/ng-update/index.ts 0.00% <0.00%> (ø)
...cts/cdk/schematics/ng-update/steps/rename-types.ts 0.00% <0.00%> (ø)
...ts/cdk/schematics/ng-update/steps/miscellaneous.ts 0.00% <0.00%> (ø)
...ts/cdk/schematics/ng-update/steps/remove-module.ts 0.00% <0.00%> (ø)
...ts/cdk/schematics/ng-update/steps/replace-const.ts 0.00% <0.00%> (ø)
...ts/cdk/schematics/ng-update/steps/replace-enums.ts 0.00% <0.00%> (ø)
...cdk/schematics/ng-update/steps/migrate-progress.ts 0.00% <0.00%> (ø)
...cdk/schematics/ng-update/steps/replace-services.ts 0.00% <0.00%> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@splincode splincode force-pushed the splincode/fix/issues/3096 branch from c98fb9b to 4f8bcd0 Compare November 29, 2022 11:38
@splincode splincode force-pushed the splincode/fix/issues/3096 branch from 4f8bcd0 to a12cd28 Compare November 29, 2022 13:04
@splincode splincode merged commit 4222293 into main Nov 29, 2022
@splincode splincode deleted the splincode/fix/issues/3096 branch November 29, 2022 18:37
@well-done-bot
Copy link

well-done-bot bot commented Nov 29, 2022

'Well done'

oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Dec 1, 2022
oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Dec 1, 2022
oknimot pushed a commit to oknimot/taiga-ui that referenced this pull request Dec 1, 2022
@tinkoff-bot tinkoff-bot mentioned this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - images are not displayed in the editor
3 participants